Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - Refactor Akushon #41

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Conversation

FaaizHaikal
Copy link
Contributor

Jira Link:

Description

  • Fix error in loading config and add logging
  • Fix pose index when playing next action
  • Use argument for action_main.cpp for flexibility in checking actions
  • Remove data config (moved to https://github.com/ichiro-its/configuration)

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

src/action_main.cpp Outdated Show resolved Hide resolved
src/action_main.cpp Outdated Show resolved Hide resolved
src/akushon/action/node/action_manager.cpp Outdated Show resolved Hide resolved
@FaaizHaikal FaaizHaikal merged commit 1c517e9 into master Apr 29, 2024
1 check failed
@FaaizHaikal FaaizHaikal deleted the enhancement/refactor-akushon branch April 29, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants